Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(test): Fix nmi postman collection #5928

Merged
merged 13 commits into from
Sep 20, 2024
Merged

ci(test): Fix nmi postman collection #5928

merged 13 commits into from
Sep 20, 2024

Conversation

Gnanasundari24
Copy link
Contributor

@Gnanasundari24 Gnanasundari24 commented Sep 17, 2024 •
edited by pixincreate
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Save card flows are failing in nmi collection. Fixed that in this PR

Motivation and Context

fix

How did you test it?

Screenshot 2024-09-17 at 9 07 20 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Gnanasundari24 Gnanasundari24 requested review from a team as code owners September 17, 2024 15:38
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Sep 17, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 5 of 9 files.

Overall, the semantic diff is 88% smaller than the GitHub diff.

1 files do not contain logic changes.

Filename Status
✔️ postman/collection-dir/nmi/Flow Testcases/Happy Cases/Scenario11-Don't Pass CVV for save card flow and verify success payment/.meta.json 75.0% smaller
❔ postman/collection-dir/nmi/Flow Testcases/Happy Cases/Scenario11-Don't Pass CVV for save card flow and verify success payment/Payments - Retrieve/.event.meta.json Unsupported file format
❔ postman/collection-dir/nmi/Flow Testcases/Happy Cases/Scenario11-Don't Pass CVV for save card flow and verify success payment/Payments - Retrieve/event.test.js Unsupported file format
❔ postman/collection-dir/nmi/Flow Testcases/Happy Cases/Scenario11-Don't Pass CVV for save card flow and verify success payment/Payments - Retrieve/request.json Unsupported file format
❔ postman/collection-dir/nmi/Flow Testcases/Happy Cases/Scenario11-Don't Pass CVV for save card flow and verify success payment/Payments - Retrieve/response.json Unsupported file format
✔️ postman/collection-dir/nmi/Flow Testcases/Happy Cases/Scenario11-Don't Pass CVV for save card flow and verify success payment/Payments - Create/event.test.js 96.57% smaller
✔️ postman/collection-dir/nmi/Flow Testcases/Happy Cases/Scenario10-Add card flow/.meta.json Analyzed
✔️ postman/collection-dir/nmi/Flow Testcases/Happy Cases/Scenario10-Add card flow/Payments - Retrieve/event.test.js No logic changes found
✔️ postman/collection-dir/nmi/Flow Testcases/Happy Cases/Scenario10-Add card flow/Payments - Retrieve/request.json 58.02% smaller

@Gnanasundari24 Gnanasundari24 self-assigned this Sep 17, 2024
@Gnanasundari24 Gnanasundari24 added the A-CI-CD Area: Continuous Integration/Deployment label Sep 17, 2024
@Gnanasundari24 Gnanasundari24 added this to the September 2024 Release milestone Sep 17, 2024
@pixincreate
Copy link
Member

can you check the checks failing?

pixincreate
pixincreate reviewed Sep 18, 2024
View reviewed changes
Cargo.lock Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you revert this change?

pixincreate
pixincreate previously approved these changes Sep 19, 2024
View reviewed changes
likhinbopanna
likhinbopanna previously approved these changes Sep 20, 2024
View reviewed changes
@pixincreate pixincreate removed request for a team September 20, 2024 08:14
@pixincreate pixincreate added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit dccb8d4 Sep 20, 2024
12 of 14 checks passed
@pixincreate pixincreate deleted the fix-nmi-postman branch September 20, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixincreate pixincreate pixincreate approved these changes

@likhinbopanna likhinbopanna likhinbopanna approved these changes

Assignees

@Gnanasundari24 Gnanasundari24

Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
None yet
Milestone
September 2024 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@Gnanasundari24 @pixincreate @likhinbopanna @SanchithHegde